-
Notifications
You must be signed in to change notification settings - Fork 81
Add setting to change the dual initial point used by barrier #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to change the dual initial point used by barrier #468
Conversation
/ok to test 26b3d82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request few minor changes, rest looks good.
python/cuopt_server/cuopt_server/utils/linear_programming/solver.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving cpp changes
/ok to test fbf60b9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-maes Lets add a test to cpp if possible
I'm not sure what you want me to test here. We are just adding another setting. I'm not sure how I could test that the setting is working without finding a problem that responds differently based on that setting. The only problem I have, that satisfies that requirement, can't be shared. |
/ok to test 2622ded |
I meant to test whether setting that option would complete the workflow and it will not error. But I will add that test in my PR. feel free to merge PR. |
/merge |
Allow users to select the initial point used for barrier.