Skip to content

Conversation

chris-maes
Copy link
Contributor

Allow users to select the initial point used for barrier.

@chris-maes chris-maes requested review from a team as code owners October 8, 2025 16:21
Copy link

copy-pr-bot bot commented Oct 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change improvement Improves an existing functionality and removed bug Something isn't working labels Oct 8, 2025
@chris-maes
Copy link
Contributor Author

/ok to test 26b3d82

Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request few minor changes, rest looks good.

Copy link
Contributor

@rg20 rg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving cpp changes

@rgsl888prabhu
Copy link
Collaborator

/ok to test fbf60b9

Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-maes Lets add a test to cpp if possible

@chris-maes
Copy link
Contributor Author

@chris-maes Lets add a test to cpp if possible

I'm not sure what you want me to test here. We are just adding another setting. I'm not sure how I could test that the setting is working without finding a problem that responds differently based on that setting. The only problem I have, that satisfies that requirement, can't be shared.

@chris-maes
Copy link
Contributor Author

/ok to test 2622ded

@rgsl888prabhu
Copy link
Collaborator

@chris-maes Lets add a test to cpp if possible

I'm not sure what you want me to test here. We are just adding another setting. I'm not sure how I could test that the setting is working without finding a problem that responds differently based on that setting. The only problem I have, that satisfies that requirement, can't be shared.

I meant to test whether setting that option would complete the workflow and it will not error. But I will add that test in my PR. feel free to merge PR.

@chris-maes
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 590c71a into NVIDIA:branch-25.10 Oct 9, 2025
172 of 174 checks passed
@chris-maes chris-maes deleted the initial_point_option branch October 9, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants