Skip to content

[BUG] Remove the check disabling windows support, and replace by checking for CUDA VMM API support #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2025
+8 −3
Merged

[BUG] Remove the check disabling windows support, and replace by checking for CUDA VMM API support #1229

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcaf139
remove unnecessary disabling
benhg Nov 10, 2025
22f2000
trim whitespace
benhg Nov 10, 2025
4a6a82f
Merge branch 'main' of github.com:benhg/cuda-python into benjaming/re…
benhg Nov 10, 2025
eb2a33f
sync main
benhg Nov 10, 2025
e6d4124
Update cuda_core/cuda/core/experimental/_memory.pyx
benhg Nov 11, 2025
b5be26d
Leo's comments
benhg Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cuda_core/cuda/core/experimental/_memory.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,8 +1208,12 @@ class VirtualMemoryResource(MemoryResource):
)
if self.config.location_type == "host":
self.device = None
if platform.system() == "Windows":
raise NotImplementedError("VirtualMemoryResource is not supported on Windows")

if device and not device.properties.virtual_memory_management_supported:
raise NotImplementedError("VirtualMemoryResource requires CUDA VMM API support")

if not device and self.config.location_type == "device":
raise ValueError("VirtualMemoryResource requires a device for device memory allocations")

# Validate RDMA support if requested
if self.config.gpu_direct_rdma and self.device is not None:
Expand Down