[BUG] Remove the check disabling windows support, and replace by checking for CUDA VMM API support #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
reviewed
Nov 10, 2025
leofang
reviewed
Nov 10, 2025
leofang
reviewed
Nov 10, 2025
leofang
reviewed
Nov 10, 2025
leofang
added
bug
rparolin
previously approved these changes
Nov 10, 2025
Co-authored-by: Leo Fang <[email protected]>
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
|
/ok to test b5be26d |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Nov 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we initially wrote this feature, I neglected to disable the functionality if VMM APIs are not supported, and instead disabled all Windows support because TCC Windows systems don't have this support. Instead, we should check for VMM APIs explicitly.