update base image to 24.12 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
|
/build-ci |
|
Did you build-ci work given that this is a fork? I actually am not certain our ci will work on forks (...this is bad if it doesn't, since fork PRs should probably be the norm so that we dont have the branch explosion that we have today). |
|
/build-ci |
Yeah it works on forks; that's pretty essential given that we're open source and not adding write-access external collaborators. IIUC that should be the recommended way to make PRs at this point, otherwise we clog up the main repo with a bunch of branches |
pstjohn
force-pushed
the
pstjohn/2412
branch
from
1ac5711 to
f0dde5a
Compare
pstjohn
requested review from
DejunL,
farhadrgh,
guoqing-zhou and
skothenhill-nv
as code owners
|
/build-ci |
trvachov
requested changes
Dec 30, 2024
trvachov
approved these changes
Dec 30, 2024
pstjohn
force-pushed
the
pstjohn/2412
branch
from
b5043f3 to
8cabfb4
Compare
|
/build-ci |
|
sudo-merging after CI passed due to folks being out of the office |
trvachov
added a commit
that referenced
this pull request
Jan 1, 2025
## Summary Un-xfails a geneformer H100 test. ## Details After base image upgrade to pytorch fw 24.12 (#553) , H100 geneformer issue is fixed. ## Usage and Testing ```python pytest ./sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values ```
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
Attempts to update the base image to the most recent 24.12 release Signed-off-by: Danny <[email protected]>
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
## Summary Un-xfails a geneformer H100 test. ## Details After base image upgrade to pytorch fw 24.12 (NVIDIA#553) , H100 geneformer issue is fixed. ## Usage and Testing ```python pytest ./sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values ``` Signed-off-by: Danny <[email protected]>
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
Attempts to update the base image to the most recent 24.12 release Signed-off-by: Danny <[email protected]>
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
## Summary Un-xfails a geneformer H100 test. ## Details After base image upgrade to pytorch fw 24.12 (NVIDIA#553) , H100 geneformer issue is fixed. ## Usage and Testing ```python pytest ./sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values ``` Signed-off-by: Danny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to update the base image to the most recent 24.12 release