Duplicates of Peter's changes for CI #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvachov
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
pstjohn
as code owners
trvachov
force-pushed
the
trvachov/cve-fixes
branch
from
e765a88 to
ccca0f9
Compare
|
/build-ci |
1 similar comment
|
/build-ci |
trvachov
force-pushed
the
trvachov/cve-fixes
branch
from
ccca0f9 to
b0dfe32
Compare
|
/build-ci |
trvachov
force-pushed
the
trvachov/cve-fixes
branch
from
7fa03ce to
25b3ef0
Compare
pstjohn
approved these changes
Dec 30, 2024
trvachov
commented
Dec 30, 2024
| RUN --mount=type=bind,source=./.git,target=./.git \ | ||
| --mount=type=bind,source=./requirements-test.txt,target=/requirements-test.txt \ | ||
| --mount=type=bind,source=./requirements-cve.txt,target=/requirements-cve.txt \ | ||
| pip install --use-deprecated=legacy-resolver --no-build-isolation --break-system-packages \ |
There was a problem hiding this comment.
How to pull correct wheel? @pstjohn
trvachov
commented
Dec 30, 2024
| # RUN source /usr/local/nvm/nvm.sh && \ | ||
| # NODE_VER=$(nvm current) && \ | ||
| # nvm deactivate && \ | ||
| # nvm uninstall $NODE_VER && \ |
There was a problem hiding this comment.
@trvachov remove comments
trvachov
commented
Jan 2, 2025
| @@ -246,6 +248,7 @@ COPY --from=rust-env /usr/local/rustup /usr/local/rustup | |||
|
|
|||
|
|
|||
| # RUN rm -rf /usr/local/cargo /usr/local/rustup | |||
| RUN rm -rf /root/.cache/bazel | |||
There was a problem hiding this comment.
@pstjohn can we add this to your PR? https://github.com/NVIDIA/bionemo-framework/pull/566/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of Peter's PR (#553) for CI testing.