Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C/PyTorch] Add support for multi-latent attention (MLA) #1039

Merged
merged 19 commits into from
Aug 6, 2024

Conversation

cyanguwa
Copy link
Collaborator

Description

This PR adds support for multi-latent attention (MLA) where head_dim_qk != head_dim_v.

This feature is only supported on the DotProductAttention level and by both UnfusedDotProductAttention backend and FusedAttention backend.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Add support for MLA

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cyanguwa
Copy link
Collaborator Author

/te-ci

@cyanguwa
Copy link
Collaborator Author

/te-ci

@cyanguwa cyanguwa requested a review from zlsh80826 July 30, 2024 19:30
@cyanguwa
Copy link
Collaborator Author

/te-ci

@cyanguwa
Copy link
Collaborator Author

cyanguwa commented Aug 2, 2024

Some CI issue. Local tests for L0_jax_unittest using the CI container pass with no problem on A100/V100.

@zlsh80826
Copy link
Collaborator

LGTM!

@cyanguwa cyanguwa merged commit 87939be into NVIDIA:main Aug 6, 2024
29 of 31 checks passed
@JiwenJ
Copy link

JiwenJ commented Nov 28, 2024

Hello, does this support qk != v head dim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants