Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Update docs/example and benchmarks/ scripts #1075

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

cyanguwa
Copy link
Collaborator

@cyanguwa cyanguwa commented Aug 2, 2024

Description

This PR updates the attention Jupyter Notebook and some of the scripts related to it in docs/example/attention and benchmarks/attention.

  • docs/example/attention/attention.ipynb
  • docs/example/attention/example_attention.py
  • docs/example/attention/arbitrary_mask_to_post_scale_bias.py
  • benchmarks/attention/benchmark_attention.py

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Update attention tutorial and docs/example and benchmarks/ scripts

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cyanguwa
Copy link
Collaborator Author

cyanguwa commented Aug 2, 2024

/te-ci pytorch

@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

@cyanguwa cyanguwa requested review from ptrendx and ksivaman August 11, 2024 23:00
@cyanguwa cyanguwa requested a review from ptrendx August 13, 2024 00:48
@ptrendx ptrendx merged commit 88c0c91 into NVIDIA:main Aug 13, 2024
25 of 26 checks passed
mgoldfarb-nvidia pushed a commit to mgoldfarb-nvidia/TransformerEngine that referenced this pull request Aug 14, 2024
* update example/benchmark scripts

Signed-off-by: Charlene Yang <[email protected]>

* fix head_dim after MLA

Signed-off-by: Charlene Yang <[email protected]>

* update notebook

Signed-off-by: Charlene Yang <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Charlene Yang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants