fix(security): update managed image dependencies - #8862
Conversation
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes update managed-image Expat pins to 2.8.3-1, pin OpenClaw and mcporter Hono to 4.12.34, refresh lockfile digests and security reviews, add ChangesSecurity and dependency pin refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-8862.docs.buildwithfern.com/nemoclaw |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agents/openclaw/dependency-review.md`:
- Line 26: Update the removal condition in the dependency review guidance to
require a new review and synchronized updates to invalidState, lockfile digests,
and tests before accepting any later Hono version; keep the exact-version gate
at 4.12.34 and preserve the mcporter test’s overridden: true expectation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0ff219ab-b288-4a8a-847b-da7a0c284f9f
⛔ Files ignored due to path filters (3)
agents/langchain-deepagents-code/requirements.lockis excluded by!**/*.lockagents/openclaw/mcporter-runtime/package-lock.jsonis excluded by!**/package-lock.jsonagents/openclaw/openclaw-runtime/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (23)
DockerfileDockerfile.baseagents/hermes/Dockerfileagents/hermes/Dockerfile.baseagents/langchain-deepagents-code/Dockerfileagents/langchain-deepagents-code/Dockerfile.baseagents/langchain-deepagents-code/dependency-review.mdagents/langchain-deepagents-code/requirements.inagents/openclaw/dependency-review.mdagents/openclaw/mcporter-runtime/package.jsonagents/openclaw/openclaw-runtime/package.jsonci/reviewed-npm-audit.jsondocs/security/openclaw-2026.7.1-dependency-review.mddocs/security/sandbox-base-2026-07-25-dependency-review.mdsrc/lib/sandbox-base-image/security-inventory.tstest/helpers/base-apt-security-functions.tstest/helpers/onboard-script-mocks.cjstest/helpers/python-parser-security-fixture.tstest/langchain-deepagents-code-image.test.tstest/mcporter-supply-chain.test.tstest/openclaw-dependency-review.test.tstest/openclaw-locked-install.test.tstest/sandbox-base-security-packages.test.ts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None Manual-only E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
|
Addressed the review findings in 34d861a: removed the unused lock digest constant and aligned the Hono override removal condition with the exact-version security gate. Focused tests pass (37/37), documentation validation passes, and the exact-head Base Images run succeeded for all three images on amd64 and arm64: https://github.com/NVIDIA/NemoClaw/actions/runs/31570611861 |
|
The updated exact head |
…locking-dependencies
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
|
Refreshed onto current |
wscurran
added
area: ci
…locking-dependencies
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
<!-- markdownlint-disable MD041 --> Update three reviewed managed-image dependency boundaries. All managed images now install Expat 2.8.3, both OpenClaw runtime locks select Hono 4.12.34, and Deep Agents Code selects `langgraph-checkpoint-sqlite` 3.1.1. - Download the architecture-specific Debian `libexpat1=2.8.3-1` packages from an immutable snapshot, verify their SHA-256 values, and assert the installed dpkg and Python Expat identities in all three managed images. - Override Hono to exact version 4.12.34 in the OpenClaw and mcporter production graphs, refresh the locks and integrity bindings, and document the compatibility boundary and removal condition. - Add a hash-locked `langgraph-checkpoint-sqlite==3.1.1` constraint to Deep Agents Code, refresh its lock, and assert the installed version before publishing the image. - Refresh the owning dependency-review records and security-package contract tests. - [ ] Code change (feature, bug fix, or refactor) - [x] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Reviewed the exact Debian, npm, and Python artifact identities, checksums or integrity values, advisory ranges, declared compatibility ranges, and removal conditions. The independent documentation review passed on the final commit. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: `agents/langchain-deepagents-code/dependency-review.md`, `agents/openclaw/dependency-review.md`, `docs/security/openclaw-2026.7.1-dependency-review.md`, and `docs/security/sandbox-base-2026-07-25-dependency-review.md` - Agent: Codex Desktop <!-- docs-review-head-sha: a5faa6a --> <!-- docs-review-agents-blob-sha: c4923a3 --> - [ ] Tested on DGX Station - Tested commit: - Station profile/scenario: - Result: - Supporting evidence: - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run validate:pr` passed after refreshing `origin/main` when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: 101 focused package and image-contract tests passed before refresh; 80 focused audit-transition tests passed after refresh; normal hooks and `git diff --check` passed. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) Additional validation: the dependency-input Base Images run succeeded for OpenClaw, Hermes, and Deep Agents Code on amd64 and arm64. `npm run docs` completed with zero errors and the two existing hidden Fern warnings. --- Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Security Updates** * Updated the Expat security package to version 2.8.3-1 across managed images and runtime checks. * Pinned Hono to version 4.12.34 to address known advisories. * Refreshed dependency audits, lockfile integrity checks, and security inventories. * **Dependency Updates** * Added SQLite checkpoint support for LangGraph with version 3.1.1. * Updated dependency validation and package inventories for more reliable builds and runtime verification. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 250d4ab)
4 participants
Summary
Update three reviewed managed-image dependency boundaries. All managed images now install Expat 2.8.3, both OpenClaw runtime locks select Hono 4.12.34, and Deep Agents Code selects
langgraph-checkpoint-sqlite3.1.1.Changes
libexpat1=2.8.3-1packages from an immutable snapshot, verify their SHA-256 values, and assert the installed dpkg and Python Expat identities in all three managed images.langgraph-checkpoint-sqlite==3.1.1constraint to Deep Agents Code, refresh its lock, and assert the installed version before publishing the image.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedagents/langchain-deepagents-code/dependency-review.md,agents/openclaw/dependency-review.md,docs/security/openclaw-2026.7.1-dependency-review.md, anddocs/security/sandbox-base-2026-07-25-dependency-review.mdDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablegit diff --checkpassed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Additional validation: the dependency-input Base Images run succeeded for OpenClaw, Hermes, and Deep Agents Code on amd64 and arm64.
npm run docscompleted with zero errors and the two existing hidden Fern warnings.Signed-off-by: Senthil Ravichandran senthilr@nvidia.com
Summary by CodeRabbit
Security Updates
Dependency Updates