fix(hermes): refresh sandbox base digest - #8928
Conversation
Signed-off-by: prekshivyas <prekshiv@nvidia.com>
Signed-off-by: prekshivyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Hermes Dockerfile and provisioning test now use a new immutable sandbox base image digest. The security review records the image publication, provenance, platform manifests, attestations, and ChangesHermes base image refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to The PR refreshes the Hermes sandbox base-image digest and documents the validated dependency provenance without changing runtime privileges or fallback behavior. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-8928.docs.buildwithfern.com/nemoclaw |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/security/hermes-0.19.0-dependency-review.md`:
- Line 333: Update the selected patched-image publication reference on the
HERMES-12 provenance record to run 31636995117, while retaining run 31031662054
only as superseded historical context. Ensure the referenced publication details
remain consistent with the latest selected OCI index.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 92ca747b-355b-45ff-b910-17aa21e99db4
📒 Files selected for processing (2)
agents/hermes/Dockerfiledocs/security/hermes-0.19.0-dependency-review.md
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
6 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None Manual-only E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: prekshivyas <prekshiv@nvidia.com>
Signed-off-by: prekshivyas <prekshiv@nvidia.com>
Summary
Refresh the Hermes sandbox base pin to the validated multi-platform image produced from the current
mainsource. The previous immutable index still containedlibexpat1==2.8.2-1, so every Hermes final-image verification job failed deterministically when it required2.8.3-1.Changes
agents/hermes/Dockerfileto OCI indexsha256:4295138e..., whose amd64 and arm64 manifests both containlibexpat1==2.8.3-1.Type of Change
Quality Gates
libexpat1==2.8.3-1install/runtime assertions. The change does not alter credential, policy, or runtime privilege boundaries.Documentation Writer Review
docs-updateddocs/security/hermes-0.19.0-dependency-review.mdCodex DesktopDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm run test:changedpassed 2 files and 30 tests; OCI inspection confirmedlibexpat1==2.8.3-1on amd64 and arm64.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: not applicable to an immutable base digest and provenance-only update.npm run docsbuilds without warnings (doc changes only)Signed-off-by: prekshivyas prekshiv@nvidia.com
Summary by CodeRabbit