[DO NOT MERGE] Update data catalog #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sandrahoang686
changed the title
sandrahoang686
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Mar 10, 2025
…og (#1479) **Related Ticket:** #1453 **Related PRs:** NASA-IMPACT/next-veda-ui#52 https://deploy-preview-1479--veda-ui.netlify.app/data-catalog https://deploy-preview-1479--veda-ui.netlify.app/sandbox/cards ### Description of Changes * Added a `BaseCard` component where `FlagCard` and `DefaultCard` extend off of * BaseCard Attributes to be used across cards * Created Fork of `CatalogContent` where we can start migrating components over to USWDS and renamed old one to `CatalogContentLegacy`. * This is FF * Updated ** - Exposed `CatalogContent` instead of `CatalogView`, updates reflected in connected NextJs PR * Added `Tags` component from USWDS * Added draft documentation of the components we are starting to expose from the library with props, I created this for now because we gotta start documenting this somewhere but we can figure out where and how best to document later * Added both card types to `/sandbox/cards` because right now we dont have a storybook(esque) implemented but right now, it looked like a fine enough place to showcase **What this doesn't do:** * DataSelectorModal isn't updated but uses the old view, @faustoperez will work on the designs for that so a separate ticket will follow * Card Accessibility states to be implemented as part of this ticket #1481 ### Notes & Questions About Changes * `FlagCard` and `DefaultCard` can be exposed as is, if exposed as is, they dont have the wrapping routing logic wrapped around it which makes it behave as a button. If the wrapping routing logic is wanted. The `Card` Component which is our wrapper to support current routing logic could be exposed and used where type `FLAG-LAYOUT` would be passed in. Users can decide. ### Validation / Testing * Validate that the Feature Flagging works `ENABLE_USWDS_DATA_CATALOG` * Validate when enabled... * DataCatalog Cards look correct * Entire card behaves like a button * The Card routes correctly * Validate that the DataSelectorModal is still the same as originally since nothing should have changed with its look or behavior _____ Self Validation Loom Walkthrough (recommended to watch @1.5x) https://www.loom.com/share/c52aa4227651422dbac9554a744f2aa8?sid=3ac71fca-189f-42ce-856c-0104ee6703c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to NASA-IMPACT/veda-ui#1479