Skip to content

Conversation

@sandrahoang686
Copy link
Collaborator

@sandrahoang686 sandrahoang686 commented Mar 27, 2025

This was originally meant to fix the DataCatalog page being broken from this PR here. (that was my bad @hanbyul-here that I wasn't able to catch that when approving).

But looks like bumping veda-ui to v6.1.1 helped fixed the issue. I did publish version 6.1.1 into our registry which is outside of the normal release schedule as this version is a patch but I just wanted to get these changes in for the demo that is supposed to happen soon as well.

Changes:

@netlify
Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for veda-ui-next-test ready!

Name Link
🔨 Latest commit 6141bab
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui-next-test/deploys/67e67edb740fb300081b8e94
😎 Deploy Preview https://deploy-preview-63--veda-ui-next-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 requested a review from aboydnw March 27, 2025 19:32
@sandrahoang686
Copy link
Collaborator Author

@aboydnw could I ask you to review this as well and if you think this looks good enough to be in a demo-able state? Or is there any tweaks or anything you think we should clean up for the demo?

@aboydnw
Copy link

aboydnw commented Mar 27, 2025

Thanks @sandrahoang686
The only thing that I thought might be worth cleaning up in time for the demo on Tuesday would be the page hero on stories. The title is not visible against the photos. In other instances I think we use a white font for this.
image

Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes for style, specifically, applying legacy style for the pages that still depend on veda ui library - (And I realized that I forgot to scope the styles for MDX components while doing it, so I put a work around it 😬 ) Other than what @aboydnw said, this should be fine but I will defert review to @dzole0311 since I already touched this 🙇

@dzole0311
Copy link
Collaborator

dzole0311 commented Mar 28, 2025

Added the missing styles for the legacy PageHero in the stories, the rest works fine for me / no errors are being thrown.

Just a note to remember: This template instance is just showcasing how the veda UI works as standalone React components (instead of the old submodule approach). And was used as a sandbox for setting the USWDS theming and Next.js infrastructure in place, and to test the refactored veda UI components. Most of the design and look & feel improvements will probably happen in the next-earth-gov project (and parts of it we can also bring back to the template instance).

@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented Mar 28, 2025

Just a note to remember: This template instance is just showcasing how the veda UI works as standalone React components (instead of the old submodule approach). And was used as a sandbox for setting the USWDS theming and Next.js infrastructure in place, and to test the refactored veda UI components. Most of the design and look & feel improvements will probably happen in the next-earth-gov project (and parts of it we can also bring back to the template instance).

@dzole0311 @aboydnw this is new to me. So are we not developing and refining the template instance to its figma designs as well? I also thought it will eventually replace veda-config / earthdata instance but that could be wrong.

@aboydnw
Copy link

aboydnw commented Mar 28, 2025

We're developing to the figma designs as a guide to rebuild core VEDA features using USWDS. The template instance should also be relatively presentable & usable because the idea is a new instance can use the template instance as a starting point, and with very limited effort have their own instance ready for release.

The template instance will not be replacing the Earthdata instance, at least that is not the current plan.

@sandrahoang686 sandrahoang686 merged commit f6ad075 into main Mar 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants