-
Notifications
You must be signed in to change notification settings - Fork 9
Bump veda-ui to v6.1.1 and catchup to changes #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aboydnw could I ask you to review this as well and if you think this looks good enough to be in a demo-able state? Or is there any tweaks or anything you think we should clean up for the demo? |
|
Thanks @sandrahoang686 |
hanbyul-here
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some changes for style, specifically, applying legacy style for the pages that still depend on veda ui library - (And I realized that I forgot to scope the styles for MDX components while doing it, so I put a work around it 😬 ) Other than what @aboydnw said, this should be fine but I will defert review to @dzole0311 since I already touched this 🙇
|
Added the missing styles for the legacy PageHero in the stories, the rest works fine for me / no errors are being thrown. Just a note to remember: This template instance is just showcasing how the veda UI works as standalone React components (instead of the old submodule approach). And was used as a sandbox for setting the USWDS theming and Next.js infrastructure in place, and to test the refactored veda UI components. Most of the design and look & feel improvements will probably happen in the next-earth-gov project (and parts of it we can also bring back to the template instance). |
@dzole0311 @aboydnw this is new to me. So are we not developing and refining the template instance to its figma designs as well? I also thought it will eventually replace |
|
We're developing to the figma designs as a guide to rebuild core VEDA features using USWDS. The template instance should also be relatively presentable & usable because the idea is a new instance can use the template instance as a starting point, and with very limited effort have their own instance ready for release. The template instance will not be replacing the Earthdata instance, at least that is not the current plan. |

This was originally meant to fix the DataCatalog page being broken from this PR here. (that was my bad @hanbyul-here that I wasn't able to catch that when approving).
But looks like bumping veda-ui to
v6.1.1helped fixed the issue. I did publish version6.1.1into our registry which is outside of the normal release schedule as this version is a patch but I just wanted to get these changes in for the demo that is supposed to happen soon as well.Changes:
DataCatalogbeing migrated over to USWDS components.[DO NOT MERGE] Update data catalog #52
[DO NOT MERGE] Refactor Data catalog filter and search component #57
[DO NOT MERGE] Temporarily deploy pagination #58