Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Phoenix editor auto indent and completion through adaptation logic #1430

Open
duranb opened this issue Aug 16, 2024 · 1 comment · May be fixed by #1446
Open

Route Phoenix editor auto indent and completion through adaptation logic #1430

duranb opened this issue Aug 16, 2024 · 1 comment · May be fixed by #1446
Assignees
Labels
refactor A code change that neither fixes a bug nor adds a feature sequencing Anything related to the sequencing domain

Comments

@duranb
Copy link
Collaborator

duranb commented Aug 16, 2024

Currently the SequenceEditor component is calling some "core" functions directly (i.e. auto-indent, auto-complete), and doesn't allow users to override it via adaptations.

We should apply the same logic that we have done for sequence output products to this for sequence input.

Also there's still a seq-json-linter.ts file and seqJsonLinter() function inside that could be renamed to more generic names since it already uses the adaptation logic.

@duranb duranb added refactor A code change that neither fixes a bug nor adds a feature sequencing Anything related to the sequencing domain labels Aug 16, 2024
@dandelany
Copy link
Collaborator

Related to the changes introduced with PR #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature sequencing Anything related to the sequencing domain
Projects
Status: In Review
3 participants