Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove sequence lang specifics #1442

Closed
wants to merge 15 commits into from
Closed

Feature/remove sequence lang specifics #1442

wants to merge 15 commits into from

Conversation

cohansen
Copy link
Contributor

Closes #1430.

Adds autoIndent and autoComplete to the sequence adaptation. I also cleaned up the linting calls so they go through extension-points again that way we're using more agnostic calls at the editor level.

@cohansen
Refactored the sequence table into its own component
26f13cc
@cohansen
Rough prototype of workspaces
2df1ed5
@cohansen
Added the sequence header back in
0919383
@cohansen
More workspace improvements, navigation and persistance working now
1d73a01
@cohansen
Added a modal to set and edit workspace names
46d03a1
@cohansen
Added the workspace name to the top of the sequence table
3c37fd4
@cohansen
Added a uniqueness check for workspace names
eef1f02
@cohansen
Added a e2e test for workspaces
5c972fc
@cohansen
Changed how the workspace test functions
9ad4548
@cohansen
Added optional objects to input parameters
49c32e3
@cohansen
Added the parsed input_parameter fields to seqjson
bf5ad31
@cohansen
Added linting rules for input parameter objects
e687612
@cohansen
Added input param metadata parsing to from-seq-json
98d6421
@cohansen
Moved the lint calls outside of lang specific files
1db8f4c
@cohansen
Added a default adaptation and hooks for auto indent and auto complete
f0140cf
@cohansen cohansen self-assigned this Aug 28, 2024
@cohansen cohansen requested a review from a team as a code owner August 28, 2024 15:41
Base automatically changed from feature/update-input-params to develop September 3, 2024 17:51
@cohansen cohansen changed the base branch from develop to auto-complete September 3, 2024 17:53
@cohansen cohansen changed the base branch from auto-complete to develop September 3, 2024 17:53
@cohansen cohansen closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@duranb duranb Awaiting requested review from duranb duranb is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@cohansen cohansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route Phoenix editor auto indent and completion through adaptation logic
1 participant
@cohansen