-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove seqjson and seqn lang specifics #1446
Feature/remove seqjson and seqn lang specifics #1446
Conversation
c9909a0
to
a324860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify that the autocomplete works? I am testing locally on my end and I am not seeing commands appear in the autocomplete box.
Are you using an adaptation or using a parcel without one? |
I am using a parcel with no adaptation. I see the command dictionary when the editor is being reconfigured but is is null when the autocomplete code is fired. editorSequenceView.dispatch({
effects: [
compartmentSeqLanguage.reconfigure(
setupLanguageSupport(
$sequenceAdaptation.autoComplete(
parsedChannelDictionary,
parsedCommandDictionary,
nonNullParsedParameterDictionaries,
),
),
), |
I just retested this and I'm seeing the command dictionary being defined, maybe we can work through this on Monday? |
a324860
to
3eb39d7
Compare
@cohansen it seems to be working now. Maybe when you forced pushed it fixed the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now working on my end :) Just resolve @duranb request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you!
* Moved the lint calls outside of lang specific files * Added a default adaptation and hooks for auto indent and auto complete * Fixed filterText not having a type and reconfiguring the sequence editor * Removed a lint problem * Fixed an issue where reconfiguring the seqn editor was throwing away all extensions * Moved auto complete to a comparment
* Moved the lint calls outside of lang specific files * Added a default adaptation and hooks for auto indent and auto complete * Fixed filterText not having a type and reconfiguring the sequence editor * Removed a lint problem * Fixed an issue where reconfiguring the seqn editor was throwing away all extensions * Moved auto complete to a comparment
Closes #1430.
Adds
autoIndent
andautoComplete
to the sequence adaptation. I also cleaned up the linting calls so they go throughextension-points
again that way we're using more agnostic calls at the editor level.