-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global_slot_since_genesis query #15779
Fix global_slot_since_genesis query #15779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff! I have also verified the test output for this graphql call on a mina daemon connected to devnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you redirect this towards the compatible
branch? The master
branch is generally for changes that we've already released (although can include infra changes as needed), whereas compatible
are those soft-forkable changes that we're staging for release.
1336e65
to
7ffbba5
Compare
!ci-build-me |
3 similar comments
!ci-build-me |
!ci-build-me |
!ci-build-me |
788f59b
to
d7e7a4a
Compare
!ci-build-me |
@mrmr1993 @MinaProtocol/infra-eng-reviewers Can someone with authority please review this change? |
!ci-build-me |
!ci-build-me |
what it does
how I tested
I synced to mainnet and ran the query there:
So the
global_slot_since_genesis
came back as564480
at block height359605
, which seems right.Checklist: