Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global_slot_since_genesis query #15779

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

martyall
Copy link
Member

what it does

how I tested

I synced to mainnet and ran the query there:

> curl -g -X POST -H "Content-Type: application/json" -d '{"query":"query { fork_config }"}' http://127.0.0.1:3085/graphql

{"data":{"fork_config":{"proof":{"fork":{"state_hash":"3NK4BpDSekaqsG6tx8Nse2zJchRft2JpnbvMiog55WCr5xJZaKeP","blockchain_length":359605,"global_slot_since_genesis":564480}}

So the global_slot_since_genesis came back as 564480 at block height 359605, which seems right.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@martyall martyall requested a review from a team as a code owner June 27, 2024 20:58
Copy link
Member

@svv232 svv232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! I have also verified the test output for this graphql call on a mina daemon connected to devnet.

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you redirect this towards the compatible branch? The master branch is generally for changes that we've already released (although can include infra changes as needed), whereas compatible are those soft-forkable changes that we're staging for release.

@martyall martyall force-pushed the martin/fix-global-slot-since-genesis-query branch from 1336e65 to 7ffbba5 Compare June 28, 2024 17:52
@martyall martyall requested a review from a team as a code owner June 28, 2024 17:52
@martyall martyall changed the base branch from master to compatible June 28, 2024 17:52
@martyall
Copy link
Member Author

!ci-build-me

3 similar comments
@svv232
Copy link
Member

svv232 commented Jun 28, 2024

!ci-build-me

@martyall
Copy link
Member Author

martyall commented Jul 1, 2024

!ci-build-me

@svv232
Copy link
Member

svv232 commented Jul 1, 2024

!ci-build-me

@martyall martyall force-pushed the martin/fix-global-slot-since-genesis-query branch from 788f59b to d7e7a4a Compare July 4, 2024 01:50
@martyall
Copy link
Member Author

martyall commented Jul 4, 2024

!ci-build-me

@martyall martyall requested a review from mrmr1993 July 17, 2024 18:04
@martyall
Copy link
Member Author

martyall commented Jul 22, 2024

@mrmr1993 @MinaProtocol/infra-eng-reviewers Can someone with authority please review this change?

@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993 mrmr1993 merged commit 0eac37c into compatible Jul 30, 2024
41 of 43 checks passed
@mrmr1993 mrmr1993 deleted the martin/fix-global-slot-since-genesis-query branch July 30, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants