New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for patch checks in CI #15791

Closed

martyall opened this issue Jul 3, 2024 · 1 comment

Assignees

Member

martyall commented Jul 3, 2024

We currently have a check_patches job that runs the following script:

#!/bin/bash

set -e

function both() { git apply $1 && git apply -R $1; }
both scripts/hardfork/localnet-patches/berkeley.patch
both buildkite/scripts/caqti-upgrade.patch
both buildkite/scripts/caqti-upgrade-plus-archive-init-speedup.patch

It is currently breaking CI for my other branch #15779 and from the standup discussion we should just be merging the changes and removing this check

The text was updated successfully, but these errors were encountered:

martyall self-assigned this

Member Author

martyall commented Jul 8, 2024 •

edited

Loading

actually it seems like this was already done 0615bf0, at least for merges with compatible

martyall closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment