Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-1203] Add OptimusSelectionCard component #656

Merged
merged 18 commits into from
Aug 15, 2024
Merged

feat: [DX-1203] Add OptimusSelectionCard component #656

merged 18 commits into from
Aug 15, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 9, 2024 •
edited
Loading

Summary

  • Added OptimusSelectionCard
  • Added Story
Preview
CleanShot.2024-08-14.at.12.51.54.mp4

Testing steps

  1. Open Selection Card story
  2. Test the component using exposed controls.

Follow-up issues

Create OptimusSelectionCardGroup wrapped with label etc.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@github-actions GitHub Actions
Copy link
Contributor

⚠️ PR has more than 300 additions. Consider splitting it into smaller PRs.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ PR has more than 300 additions. Consider splitting it into smaller PRs.

@witwash witwash added the ignore-size Ignore the size of this PR label Aug 12, 2024
@witwash witwash mentioned this pull request Aug 12, 2024
Merged
@witwash witwash marked this pull request as ready for review August 14, 2024 10:54
@witwash witwash requested a review from a team as a code owner August 14, 2024 10:54
@witwash
Copy link
Contributor Author

witwash commented Aug 14, 2024

I'll wait until we merge DCM one, to fix errors here as well

@witwash witwash merged commit 75e36f1 into master Aug 15, 2024
6 checks passed
@witwash witwash deleted the DX-1203 branch August 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil