Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-2116] Refactor Radio Circle #657

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat: [DX-2116] Refactor Radio Circle #657

merged 1 commit into from
Aug 13, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Aug 12, 2024

Summary

  • moved RadioCircle outside of the OptimusRadio component as I'm going to reuse it elsewhere.
  • refactored RadioCircle and themed it using WidgetStateProperty

Testing steps

Most of it is jut moving around and refactoring

  1. Open Radio/Radio Group story
  2. Test if Radio/RadioGroup component behaves as expected.

Follow-up issues

#656

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review August 12, 2024 12:08
@witwash witwash requested a review from a team as a code owner August 12, 2024 12:08
@witwash witwash merged commit 0c4adde into master Aug 13, 2024
7 checks passed
@witwash witwash deleted the DX-2116 branch August 13, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil