Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade to DCM 1.12.0 #492

Merged
merged 2 commits into from
Dec 18, 2023
Merged

feat!: Upgrade to DCM 1.12.0 #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a23a1b0
feat!: Upgrade to DCM 1.12.0
witwash Dec 11, 2023
823f210
refactor: Remove ignores for disabled rule
witwash Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dcm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
uses: CQLabs/setup-dcm@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
version: "1.11.1"
version: "1.12.1"

- uses: ./.github/actions/setup

Expand Down
11 changes: 8 additions & 3 deletions mews_pedantic/lib/analysis_options.yaml
View file
Open in desktop
ookami-kb marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ dart_code_metrics:
- avoid-duplicate-named-imports
- avoid-duplicate-patterns
- avoid-duplicate-switch-case-conditions
- avoid-duplicate-test-assertions
# - avoid-dynamic
- avoid-equal-expressions
- avoid-explicit-pattern-field-name
Expand All @@ -292,6 +293,7 @@ dart_code_metrics:
# - avoid-missing-enum-constant-in-map
- avoid-missing-interpolation
# - avoid-missing-test-files
- avoid-misused-test-matchers
- avoid-misused-wildcard-pattern
- avoid-mixing-named-and-positional-fields
# - avoid-mutating-parameters
Expand Down Expand Up @@ -325,7 +327,7 @@ dart_code_metrics:
# - avoid-throw-in-catch-block
# - avoid-throw-objects-without-tostring
# - avoid-top-level-members-in-tests
- avoid-unassigned-late-fields-keyword
- avoid-unassigned-late-fields
- avoid-uncaught-future-errors
- avoid-unconditional-break
- avoid-unnecessary-call
Expand Down Expand Up @@ -380,6 +382,7 @@ dart_code_metrics:
- no-object-declaration
# - parameters-ordering
# - prefer-addition-subtraction-assignments
- prefer-any-or-every
# - prefer-async-await
- prefer-both-inlining-annotations
# - prefer-bytes-builder
Expand All @@ -389,7 +392,7 @@ dart_code_metrics:
- prefer-correct-error-name
- prefer-correct-for-loop-increment
- prefer-correct-future-return-type
- prefer-correct-handler-name
# - prefer-correct-handler-name
# - prefer-correct-identifier-length
- prefer-correct-json-casts
- prefer-correct-setter-parameter-name
Expand Down Expand Up @@ -424,10 +427,12 @@ dart_code_metrics:
- prefer-simpler-patterns-null-check
- prefer-specific-cases-first
# - prefer-static-class
- prefer-switch-with-enums
# - prefer-test-matchers
# - prefer-trailing-comma
- prefer-type-over-var
- prefer-typedefs-for-callbacks
- prefer-typedefs-for-callbacks:
ignore-parameters: true
- prefer-unique-test-names
# - prefer-unwrapping-future-or
# - prefer-visible-for-testing-on-members
Expand Down
3 changes: 0 additions & 3 deletions optimus/lib/src/typography/highlight.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class OptimusHighlightMajor extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset600b,
align: align,
child: child,
Expand All @@ -52,7 +51,6 @@ class OptimusHighlightModerate extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset500b,
align: align,
child: child,
Expand All @@ -78,7 +76,6 @@ class OptimusHighlightMinor extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset400b,
align: align,
child: child,
Expand Down
4 changes: 0 additions & 4 deletions optimus/lib/src/typography/title.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ class OptimusPageTitle extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset700b,
align: align,
child: child,
Expand All @@ -49,7 +48,6 @@ class OptimusSectionTitle extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset600b,
align: align,
child: child,
Expand All @@ -75,7 +73,6 @@ class OptimusSubsectionTitle extends StatelessWidget {

@override
Widget build(BuildContext context) => OptimusTypography(
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset500b,
align: align,
child: child,
Expand All @@ -101,7 +98,6 @@ class OptimusSubtitle extends StatelessWidget {
@override
Widget build(BuildContext context) => OptimusTypography(
color: OptimusTypographyColor.secondary,
// ignore: prefer-correct-handler-name, false trigger on global function
resolveStyle: preset400b,
align: align,
child: child,
Expand Down