Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Upgrade to DCM 1.12.0 #492

Merged
merged 2 commits into from
Dec 18, 2023
Merged

feat!: Upgrade to DCM 1.12.0 #492

merged 2 commits into from
Dec 18, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Dec 11, 2023 •
edited
Loading

Summary

Upgraded to DCM 1.12.0

Enabled rules:

Disabled rules:

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review December 11, 2023 16:07
@witwash witwash requested a review from a team December 11, 2023 16:07
@witwash witwash requested a review from ookami-kb December 13, 2023 13:12
@witwash witwash enabled auto-merge December 13, 2023 13:15
@witwash witwash merged commit 13899a5 into master Dec 18, 2023
6 checks passed
@witwash witwash deleted the dcm-1.12.0 branch December 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb