Skip to content

feat: migrate to @metamask/messenger-cli for action types codegen#579

Open
cryptodev-2s wants to merge 10 commits intomainfrom
feat/messenger-cli-action-types
Open

feat: migrate to @metamask/messenger-cli for action types codegen#579
cryptodev-2s wants to merge 10 commits intomainfrom
feat/messenger-cli-action-types

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Apr 4, 2026

Explanation

Migrates from the deprecated messenger-generate-action-types binary in @metamask/messenger to the new standalone @metamask/messenger-cli package.

Changes

  • Add @metamask/messenger-cli@^0.1.0 as devDependency
  • Add per-package scripts:
    • messenger-action-types:check — checks if generated files are up to date
    • messenger-action-types:generate — generates/updates action type files
  • Integrate into lint (--check) and lint:fix (--generate)
  • Remove old generate-method-action-types script

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate

Note

Low Risk
Low risk: changes are limited to dev tooling/scripts and dependency bumps for action-type codegen, with no runtime controller logic modifications.

Overview
Migrates messenger action-type code generation from the repo’s custom scripts/generate-method-action-types.ts (and tsx) to the standalone @metamask/messenger-cli messenger-action-types commands, wiring it into lint and lint:fix.

Updates dependencies/lockfile accordingly (adds @metamask/messenger-cli, removes tsx and related transitive deps) and tweaks generated action-type file headers plus the changelog entry to reflect the @metamask/messenger bump.

Reviewed by Cursor Bugbot for commit ae4a91a. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 4, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​messenger-cli@​0.1.0761007589100

View full report

@cryptodev-2s cryptodev-2s marked this pull request as ready for review April 4, 2026 10:06
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner April 4, 2026 10:06
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ae4a91a. Configure here.

"prettier-plugin-packagejson": "^2.4.3",
"sinon": "^9.2.4",
"ts-jest": "^29.1.4",
"tsx": "^4.20.5",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused yargs devDependency not removed with deleted script

Low Severity

The yargs devDependency was only directly used by the now-deleted scripts/generate-method-action-types.ts. The PR correctly removed tsx (the other dependency exclusive to that script) but missed removing yargs. While @metamask/messenger-cli depends on yargs transitively, the explicit devDependency is no longer needed and adds unnecessary noise to the dependency list.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ae4a91a. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant