feat: migrate to @metamask/messenger-cli for action types codegen#579
feat: migrate to @metamask/messenger-cli for action types codegen#579cryptodev-2s wants to merge 10 commits intomainfrom
Conversation
- Delete local scripts/generate-method-action-types.ts (755 lines) - Bump @metamask/messenger from ^0.3.0 to ^1.1.0 - Remove tsx devDependency (no longer needed) - Update generate script to use messenger-generate-action-types CLI
This reverts commit 566b7ff.
This reverts commit c18ae36.
…enerate-action-types-cli
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae4a91a. Configure here.
| "prettier-plugin-packagejson": "^2.4.3", | ||
| "sinon": "^9.2.4", | ||
| "ts-jest": "^29.1.4", | ||
| "tsx": "^4.20.5", |
There was a problem hiding this comment.
Unused yargs devDependency not removed with deleted script
Low Severity
The yargs devDependency was only directly used by the now-deleted scripts/generate-method-action-types.ts. The PR correctly removed tsx (the other dependency exclusive to that script) but missed removing yargs. While @metamask/messenger-cli depends on yargs transitively, the explicit devDependency is no longer needed and adds unnecessary noise to the dependency list.
Reviewed by Cursor Bugbot for commit ae4a91a. Configure here.


Explanation
Migrates from the deprecated
messenger-generate-action-typesbinary in@metamask/messengerto the new standalone@metamask/messenger-clipackage.Changes
@metamask/messenger-cli@^0.1.0as devDependencymessenger-action-types:check— checks if generated files are up to datemessenger-action-types:generate— generates/updates action type fileslint(--check) andlint:fix(--generate)generate-method-action-typesscriptReferences
Checklist
Note
Low Risk
Low risk: changes are limited to dev tooling/scripts and dependency bumps for action-type codegen, with no runtime controller logic modifications.
Overview
Migrates messenger action-type code generation from the repo’s custom
scripts/generate-method-action-types.ts(andtsx) to the standalone@metamask/messenger-climessenger-action-typescommands, wiring it intolintandlint:fix.Updates dependencies/lockfile accordingly (adds
@metamask/messenger-cli, removestsxand related transitive deps) and tweaks generated action-type file headers plus the changelog entry to reflect the@metamask/messengerbump.Reviewed by Cursor Bugbot for commit ae4a91a. Bugbot is set up for automated code reviews on this repo. Configure here.