chore: use @metamask/messenger CLI for action type generation#577
Open
cryptodev-2s wants to merge 4 commits intomainfrom
Open
chore: use @metamask/messenger CLI for action type generation#577cryptodev-2s wants to merge 4 commits intomainfrom
cryptodev-2s wants to merge 4 commits intomainfrom
Conversation
- Delete local scripts/generate-method-action-types.ts (755 lines) - Bump @metamask/messenger from ^0.3.0 to ^1.1.0 - Remove tsx devDependency (no longer needed) - Update generate script to use messenger-generate-action-types CLI
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mcmire
reviewed
Apr 1, 2026
| "scripts": { | ||
| "build": "ts-bridge --project tsconfig.build.json --clean", | ||
| "generate-method-action-types": "tsx ./scripts/generate-method-action-types.ts ./src", | ||
| "generate-method-action-types": "messenger-generate-action-types", |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the local
scripts/generate-method-action-types.ts(755 lines) with themessenger-generate-action-typesCLI shipped in@metamask/messenger@^1.1.0.@metamask/messengerfrom^0.3.0to^1.1.0tsxdevDependency (no longer needed)References
Checklist
Note
Medium Risk
Medium risk because it upgrades
@metamask/messengerto^1.1.0and changes the action-type generation path, which could affect build/lint output and downstream dependency resolution.Overview
Switches method-action-type generation from the repo’s custom
scripts/generate-method-action-types.tsto themessenger-generate-action-typesCLI shipped with@metamask/messenger.Bumps
@metamask/messengerto^1.1.0(including a new Yarnresolutionspin), removes thetsxdevDependency and related LavaMoat allowlist entry, and updates the generatedSmartTransactionsControlleraction-types header comment accordingly. The changelog is updated to reflect the messenger bump.Written by Cursor Bugbot for commit 566b7ff. This will update automatically on new commits. Configure here.