Skip to content

fix: don't poll indefinitely for bridge status if 500 errors #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 21, 2025
+704 −8
Merged

fix: don't poll indefinitely for bridge status if 500 errors #6149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
88bb5dc
fix: stop bridgeStatus polling if max attempts reached (1st commit)
infiniteflower Jul 18, 2025
4a3aee6
chore: move attempts into history item so it can be persisted
infiniteflower Jul 18, 2025
516436f
chore: check if we should skip fetch on reboot
infiniteflower Jul 18, 2025
f9c9831
fix: stop at greater than or equal to max attempts
infiniteflower Jul 18, 2025
bc0e848
chore: set max attempts to something reasonable
infiniteflower Jul 18, 2025
5b808d1
feat: add resetAttempts method so clients can manually retry on click…
infiniteflower Jul 18, 2025
404a7e2
chore: export max attempts
infiniteflower Jul 18, 2025
e1909d7
chore: add comment about deprecated method startPollingForBridgeTxStatus
infiniteflower Jul 18, 2025
f377a3a
chore: clean up
infiniteflower Jul 18, 2025
6ca9034
chore: don't need to clear attempts on final status
infiniteflower Jul 18, 2025
aeba2ec
chore: move shouldSkipFetchDueToFetchFailures to utils since its pure
infiniteflower Jul 18, 2025
7fc8174
chore: add tests
infiniteflower Jul 18, 2025
17f91a6
fix: broken tests
infiniteflower Jul 18, 2025
fbb7d1b
chore: add tests for resetAttempts
infiniteflower Jul 18, 2025
fe23974
chore: add test for restarting polling on resetAttempt
infiniteflower Jul 18, 2025
403727c
chore: adjust tests
infiniteflower Jul 18, 2025
e64d69f
chore: add more asserts
infiniteflower Jul 18, 2025
0a274ac
chore: get coverage green, skip failing tests for now
infiniteflower Jul 19, 2025
415e4a5
chore: adjust test
infiniteflower Jul 19, 2025
93ac927
chore: adjust test
infiniteflower Jul 19, 2025
b614262
chore: remove tests
infiniteflower Jul 19, 2025
f4d877b
chore: changelog
infiniteflower Jul 21, 2025
25dbca8
chore: changelog
infiniteflower Jul 21, 2025
6d9f6be
chore: just set attempts in the new history item on successful fetch
infiniteflower Jul 21, 2025
0e92798
chore: make fn name more clear
infiniteflower Jul 21, 2025
c711161
fix: exports
infiniteflower Jul 21, 2025
ee56070
Merge branch 'main' into swaps-655-bridge-status-indefinite-poll-2
infiniteflower Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bridge-status-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Bump `@metamask/keyring-api` from `^18.0.0` to `^19.0.0` ([#6146](https://github.com/MetaMask/core/pull/6146))

### Fixed

- Don't poll indefinitely for bridge tx status if the tx is not found. Implement exponential backoff to prevent overwhelming the bridge API. ([#6149](https://github.com/MetaMask/core/pull/6149))

## [36.0.0]

### Changed
Expand Down
Loading
Loading