-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#982 statehost config option should be used to see pick state directory #1003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good based on explanation provided. Approving.
This branch forked from development several weeks ago, and there have been several breaking changes since then. I'm running some tests to see if rebasing helps. will see. |
…rror handling of broken sockets
so rebased from development trying to get all the tests to pass, and noticed that python3.6 cannot handle the type hints that I had provided on a later version. So removed them entirely. We should see more tests pass as a result. |
have merged these changes into #1010 to get it's tests to pass... this pull is perhaps no longer needed? |
Prior to this change, when a statehost directory existed for a given configuration,
the values in the statehost directory would override those in the non-statehost one.
e.g.:
The ~/.cache/sr3/sarra/download_f20/ directory contained correct .pid files for the
three instances that were running, but sr status indicated it that the instances were
orphans because, after reading that state directory, it then read ~/.cache/sr3/hostname/sarra/download_f20, which had no .pid files.
When reading the second directory, it was resetting the known instances to empry,
and then, because the directory was empy, never adding any values back.
This change causes the config settings to be used to select the state directory, based
on the statehost setting.