#982 statehost config option should be used to see pick state directory #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann,
andreleblanc11 and
mshak2
andreleblanc11
approved these changes
Apr 3, 2024
|
This branch forked from development several weeks ago, and there have been several breaking changes since then. I'm running some tests to see if rebasing helps. will see. |
…rror handling of broken sockets
|
so rebased from development trying to get all the tests to pass, and noticed that python3.6 cannot handle the type hints that I had provided on a later version. So removed them entirely. We should see more tests pass as a result. |
|
have merged these changes into #1010 to get it's tests to pass... this pull is perhaps no longer needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when a statehost directory existed for a given configuration,
the values in the statehost directory would override those in the non-statehost one.
e.g.:
The ~/.cache/sr3/sarra/download_f20/ directory contained correct .pid files for the
three instances that were running, but sr status indicated it that the instances were
orphans because, after reading that state directory, it then read ~/.cache/sr3/hostname/sarra/download_f20, which had no .pid files.
When reading the second directory, it was resetting the known instances to empry,
and then, because the directory was empy, never adding any values back.
This change causes the config settings to be used to select the state directory, based
on the statehost setting.