Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue997 - Eliminate retry file race condition and make AM work more like a sarracenia flow #1005

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

andreleblanc11
Copy link
Member

@andreleblanc11 andreleblanc11 commented Mar 28, 2024

Solves #997

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@petersilva petersilva merged commit 6a8272b into development Mar 28, 2024
2 of 4 checks passed
@gcglinton
Copy link
Contributor

This broke the retry unit tests, because the driver selection got moved from __init__ into on_start, so now none of the test logic works.

In all the failing tests of retry_test.py, it should be enough to call retry_disk.on_start() or retry_redis.on_start() right after those retry objects (retry_disk, retry_redis) are instantiated. Like right after lines 75, 82, 109, 115, etc..

@petersilva
Copy link
Contributor

petersilva commented Apr 5, 2024

yes the I found the same issue, there is a a commit 25df985
It is in the other PR ( #1003 )

@petersilva petersilva deleted the issue997 branch May 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants