fix(sdk): fix the required params of the setDocument() command
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectID is now required for setDocument()
Test whether setDocument() throws on invalid input data.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 5, 2024
jgreywolf
approved these changes
Apr 10, 2024
aloisklink
deleted the
fix/setDocument-specify-that-projectID-is-required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setDocument()(akaPUT /rest-api/documents/{documentID}) command in the REST API now doesn't need anidparam, but it does need aprojectIDparameter.Since
setDocument()hasn't yet been released to NPM, we don't need to yet update the CHANGELOG.md file.This fixes the E2E tests that were failing in this repo (e.g. https://github.com/Mermaid-Chart/plugins/actions/runs/7952846469/job/22299559265).