test(sdk): fix typescript error in tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocking a function with overloaded types wasn't working well.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jgreywolf
approved these changes
Apr 18, 2024
Base automatically changed from
test/make-e2e-sdk-tests-more-configurable
to
main
April 22, 2024 04:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on top of:
setDocument()command #17Please only merge this PR after those PR has been merged.
Mocking a function with overloaded types wasn't working well and causes TypeScript issues, when using a more strict TypeScript config.
The issue is that the real
OAuth2Client.requestfunction has different return types based on theirendpointparameter, and that's not something that's easy to mock, while making TypeScript happy.