Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Logic In Prisoner Nag And Updated Unit Tests #6279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllianiCBT
Copy link
Collaborator

  • Corrected the logic in PrisonersNagLogic.hasPrisoners to ensure accurate handling of active contract and prisoner status.
  • Updated unit tests in PrisonersNagLogicTest to reflect the corrected behavior and ensure proper validation.

Fix #6276

- Corrected the logic in `PrisonersNagLogic.hasPrisoners` to ensure accurate handling of active contract and prisoner status.
- Updated unit tests in `PrisonersNagLogicTest` to reflect the corrected behavior and ensure proper validation.
@IllianiCBT IllianiCBT added Bug Severity: Medium Issues described as medium severity as per the new issue form labels Mar 14, 2025
@IllianiCBT IllianiCBT self-assigned this Mar 14, 2025
@IllianiCBT IllianiCBT changed the title Fixed Logic In PrisonersNagLogic And Updated Unit Tests Fixed Logic In Prisoner Nag And Updated Unit Tests Mar 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.87%. Comparing base (0433438) to head (01f291c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6279      +/-   ##
============================================
- Coverage     10.87%   10.87%   -0.01%     
+ Complexity     6261     6259       -2     
============================================
  Files          1065     1065              
  Lines        141018   141018              
  Branches      21021    21021              
============================================
- Hits          15339    15338       -1     
+ Misses       124138   124134       -4     
- Partials       1541     1546       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]Getting POW nag when advancing days with no POW's
2 participants