Fixed Enemy Picker Logic And Added Faction Validation

[IllianiCBT]

• Updated conditional logic to consistently exclude the ROS faction after the FORTRESS_REPUBLIC date.
• Added error handling in AtBDynamicScenarioFactory:
  • Logged an error and set a fallback faction if the faction code is blank.
  • Logged an error and aborted force generation if the faction is null.

Dev Notes

I stumbled onto this completely by accident. But basically, ROS isn't a valid employer or enemy once the Wall goes up. However, there was a single missed instance where the Republic could still be chosen as an enemy. However, because it wasn't valid the faction would be null resulting in a bunch of unfortunate weirdness.

While investigating this I also added some null faction protection to force generation.

Marking this as 'high' as this issue is most prevalent in ilClan, the current era.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.88%. Comparing base (0433438) to head (cd733e9).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6278   +/-   ##
=========================================
  Coverage     10.87%   10.88%           
- Complexity     6261     6263    +2     
=========================================
  Files          1065     1065           
  Lines        141018   141028   +10     
  Branches      21021    21025    +4     
=========================================
+ Hits          15339    15346    +7     
- Misses       124138   124141    +3     
  Partials       1541     1541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.