Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Weight Bypass Based on Role #5902

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

IllianiCBT
Copy link
Collaborator

  • Introduced a helper method to handle weight class bypass logic based on specific mission roles, ensuring better unit generation outcomes in constrained scenarios.
  • Replaced fully qualified MissionRole enum references with direct imports to simplify code and improve readability.

Fix #5823

Replaced fully qualified `MissionRole` enum references with direct imports to simplify code and improve readability. Introduced a helper method to handle weight class bypass logic based on specific mission roles, ensuring better unit generation outcomes in constrained scenarios.
@IllianiCBT IllianiCBT added the Force Generation Anything related to Force Generation (Opfor or Friendly) label Jan 27, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 27, 2025
Updated the copyright notice in AtBDynamicScenarioFactory.java to reflect the current year. Ensured proper attribution for ongoing development and maintenance.
@IllianiCBT IllianiCBT changed the title Refactor mission role references for cleaner imports Added Weight Bypass Based on Role Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.29%. Comparing base (765c7bd) to head (ea091eb).
Report is 43 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5902      +/-   ##
============================================
- Coverage     10.30%   10.29%   -0.01%     
+ Complexity     6129     6127       -2     
============================================
  Files          1038     1038              
  Lines        139154   139162       +8     
  Branches      20609    20612       +3     
============================================
- Hits          14335    14329       -6     
- Misses       123424   123438      +14     
  Partials       1395     1395              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit f9c71db into MegaMek:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Force Generation Anything related to Force Generation (Opfor or Friendly)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Exclude weight class when generating units with certain roles
2 participants