Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Morale Logic and Contract Type Checks #5890

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Simplified morale roll outcomes by consolidating default cases.
  • Updated contract type checks to better handle Relief Duty contracts.
  • Ensured only Garrison Duty contracts changed the OpFor faction when ending a rout. This will stop Rebel OpFors suddenly turning into Clan OpFors on Security Duty and similar contracts.

Fix #5885

- Simplified morale roll outcomes by consolidating default cases.
- Updated contract type checks to better handle Relief Duty contracts.
- Ensured only Garrison Duty contracts changed the OpFor faction when ending a rout. This will stop Rebel OpFors suddenly turning into Clan OpFors on Security Duty and similar contracts.
@IllianiCBT IllianiCBT added Bug AtB StratCon Bugs relating strictly to StratCon labels Jan 26, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (765c7bd) to head (2d08623).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5890   +/-   ##
=========================================
  Coverage     10.30%   10.30%           
- Complexity     6129     6131    +2     
=========================================
  Files          1038     1038           
  Lines        139154   139153    -1     
  Branches      20609    20609           
=========================================
+ Hits          14335    14337    +2     
+ Misses       123424   123422    -2     
+ Partials       1395     1394    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 6d6ae59 into MegaMek:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB Bug StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.02] Early contract end on Relief Duty contract
2 participants