Refactored Personnel Cleanup and Random Dependent Removal #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlined logic for dependent removal and personnel status checks, incorporating genealogy-based validations to prevent unintended removals. Added an `isActive` method to `Genealogy` to identify active family links and updated resource strings for improved clarity.
Previously, personnel removal was processed on the last day of the month. This change ensures it now runs at the start of the month, aligning better with other monthly processes and improving data handling consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5871 +/- ##
============================================
- Coverage 10.35% 10.34% -0.02%
+ Complexity 6163 6160 -3
============================================
Files 1039 1039
Lines 139359 139382 +23
Branches 20639 20648 +9
============================================
- Hits 14428 14416 -12
- Misses 123503 123536 +33
- Partials 1428 1430 +2 ☔ View full report in Codecov by Sentry. |
rjhancock
requested changes
Feb 1, 2025
Updated the dependent departure message logic to correctly use singular or plural form based on the number of dependents. Added new resource strings for localization and adjusted the message formatting accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isActivemethod toGenealogyto identify active family linksFix #5695