Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAW CamOps Delivery Times #5852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RAW CamOps Delivery Times #5852

wants to merge 1 commit into from
+70 −247

Conversation

IllianiCBT
Copy link
Collaborator

  • Standardized transit time to follow CamOps rules.
  • Reduced campaign options to just determine whether the delivery scale is days, weeks, or months. RAW is months.

@IllianiCBT
Simplify delivery transit time calculation logic
d0e1ed6 
Removed redundant margin of success (MoS) and minimum delivery time configuration for transit calculations. Standardized transit time determination using item availability, campaign settings, and a random roll. Updated the UI and campaign options to align with the simplified calculation method.
@IllianiCBT IllianiCBT added the Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule label Jan 22, 2025
@IllianiCBT IllianiCBT self-assigned this Jan 22, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (899ef61) to head (d0e1ed6).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5852      +/-   ##
============================================
- Coverage     10.31%   10.30%   -0.01%     
+ Complexity     6128     6122       -6     
============================================
  Files          1038     1038              
  Lines        138806   138909     +103     
  Branches      20551    20574      +23     
============================================
- Hits          14322    14319       -3     
- Misses       123094   123195     +101     
- Partials       1390     1395       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT added New Feature Used with the RFE tag to indicate a new feature For New Dev Cycle and removed New Feature Used with the RFE tag to indicate a new feature labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scoppio Scoppio Scoppio approved these changes

Assignees

@IllianiCBT IllianiCBT

Labels
For New Dev Cycle Implementation of Missing Official Rule Used with the RFE tag for the implementation of missing official rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IllianiCBT @codecov-commenter @Scoppio