Skip to content

Commit

Permalink
fix: Avoid error message display on page display when session timeout -
Browse files Browse the repository at this point in the history
MEED-7171 - Meeds-io/meeds#2249 (#510)

Prior to this change, when displaying a page while the session timed
out, an alert message is displayed. This change ensures to display the
alert message only when the user makes an action on Kudos module and not
on loading time.
  • Loading branch information
boubaker authored and exo-swf committed Jul 9, 2024
1 parent c27fb76 commit 95ea49c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,5 @@ kudos.administration.label=Decide the number of kudos available for a period
kudos.administration.apply=Apply
kudos.administration.cancel=Cancel
kudos.administration.reset=Reset

kudos.unkownErrorWhileRetrievingSettings=An unknown error happened while retrieving kudos settings. Please try again later or contact the administrator.
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,7 @@ export default {
this.allKudosSent = allKudos && allKudos.kudos || [];
});
})
.catch(e => {
this.error = e;
});
.catch(e => console.debug(e));
},
closeDrawer() {
this.resetAudienceChoice();
Expand Down Expand Up @@ -533,7 +531,7 @@ export default {
this.entityOwner = null;
})
.catch(e => {
this.error = String(e);
this.error = this.$te(e?.message) ? this.$t(e.message) : this.$t('kudos.unkownErrorWhileRetrievingSettings');
console.error('Error retrieving entity details with type and id', this.entityType, this.entityId, e);
});
}
Expand Down

0 comments on commit 95ea49c

Please sign in to comment.