Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup testcases that had hard coded Date() values which override the testcase runner #3601

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ _This release is scheduled to be released on 2025-01-01._
- [core] Fix loading node_helper of modules: avoid black screen, display errors and continue loading with next module (#3578)
- [weather] changed default value for weatherEndpoint of provider openweathermap to "/onecall" (#3574)
- [tests] fix electron tests with mock dates, the mock on server side was missing (#3597)
- [tests] fix testcases with hard coded Date.now (#3597)

## [2.29.0] - 2024-10-01

Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_la_at_midnight_dst.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("19 Oct 2023 12:30:00 GMT-07:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_la_at_midnight_std.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("19 Oct 2023 12:30:00 GMT-07:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_la_before_midnight.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("19 Oct 2023 12:30:00 GMT-07:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_syd_at_midnight_dst.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("14 Sep 2023 12:30:00 GMT+10:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_syd_at_midnight_std.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("14 Sep 2023 12:30:00 GMT+10:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/exdate_syd_before_midnight.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ let config = {
]
};

Date.now = () => {
return new Date("14 Sep 2023 12:30:00 GMT+10:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/rrule_until.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ let config = {
]
};

Date.now = () => {
return new Date("07 Mar 2024 10:38:00 GMT-07:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
4 changes: 0 additions & 4 deletions tests/configs/modules/calendar/sliceMultiDayEvents.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ let config = {
]
};

Date.now = () => {
return new Date("01 Sept 2024 10:38:00 GMT+2:00").valueOf();
};

/*************** DO NOT EDIT THE LINE BELOW ***************/
if (typeof module !== "undefined") {
module.exports = config;
Expand Down
Loading