Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup testcases that had hard coded Date() values which override the testcase runner #3601

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Cleanup testcases that had hard coded Date() values which override the testcase runner #3601

merged 1 commit into from
Oct 25, 2024

Conversation

sdetweil
Copy link
Collaborator

cleanup testcases with hard coded Date settings after #3597

@sdetweil sdetweil changed the base branch from master to develop October 25, 2024 18:41
@sdetweil
Copy link
Collaborator Author

i edited and changed to develop, job rerun wont chamge altho other jobs do

@khassel
Copy link
Collaborator

khassel commented Oct 25, 2024

yes, I think if it was master at the beginning this test will always fail. Will merge it now.

@khassel khassel merged commit c96326b into MagicMirrorOrg:develop Oct 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdetweil @khassel