-
Notifications
You must be signed in to change notification settings - Fork 734
doc: Add missing contributors for v2.10.0 (closes #5136) #5139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
doc: Add missing contributors for v2.10.0 (closes #5136) #5139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
package/AUTHORS
Outdated
| - Matthew Davies | ||
| - Jia-Xin Zhu | ||
| - Tanish Yelgoe | ||
| Here is the updated list for you to copy and paste into the `! AUTHORS` file. I have added `Pradyumn-cloud` to the end of the 2025 list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a leftover comment from an LLM / AI coding tool?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5139 +/- ##
===========================================
+ Coverage 92.68% 92.73% +0.04%
===========================================
Files 180 180
Lines 22452 22452
Branches 3186 3186
===========================================
+ Hits 20809 20820 +11
- Misses 1169 1176 +7
+ Partials 474 456 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove the odd comment in the authors file.
- Did you check that there were no other authors missing? The list in the original issue was not an exhaustive list but rather just "those that I came across".
|
Hi Irfan, thanks for the review! I've removed the stray comment and pushed the fix. I also went through all the PRs listed in the 2.10.0 changelog and checked their authors against the contributor list. It looks like the 5 authors from the issue were the only ones missing. I believe the list is complete now. Thanks again! |
Fixes #5136
Changes made in this Pull Request:
CHANGELOGfile.! AUTHORSfile.PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE is my own original work.
📚 Documentation preview 📚: https://mdanalysis--5139.org.readthedocs.build/en/5139/