Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track external android format #1695

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ziga-lunarg
Copy link
Contributor

The external format from android must be tracked, because in GetImageResourceSizesOptimal we create temporary images from the same format to calculate the resource size

If format is VK_FORMAT_UNDEFINED and the external android format is not provided it will crash on android

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 245923.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 245925.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4725 running.

Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except possibly using the convenience function if it fits.

What would a minimal test program for this case look like?

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4725 passed.

The external format from android must be tracked, because in
GetImageResourceSizesOptimal we create temporary images from the same
format to calculate the resource size

If format is VK_FORMAT_UNDEFINED and the external android format is not
provided it will crash on android
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 246259.

@ziga-lunarg
Copy link
Contributor Author

Looks good to me except possibly using the convenience function if it fits.

What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4729 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4729 passed.

@bradgrantham-lunarg
Copy link
Contributor

Looks good to me except possibly using the convenience function if it fits.
What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

Do we have a capture we could put in CI that replicates this or could you quickly write a program to replicate this?

@ziga-lunarg
Copy link
Contributor Author

Looks good to me except possibly using the convenience function if it fits.
What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

Do we have a capture we could put in CI that replicates this or could you quickly write a program to replicate this?

I do have a capture, but I've realized this fix is not enough. There is another problem later in the capture, that I thought was unrelated, but it seems that it is.

@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Oct 7, 2024
@bradgrantham-lunarg
Copy link
Contributor

Can this be merged or is it part of a later PR?

@ziga-lunarg
Copy link
Contributor Author

Can this be merged or is it part of a later PR?

I might close this and open a different PR, because this only fixes a small part of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Prevents an important capture from being replayed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants