Skip to content

fix: proposed fix for pnpm dev #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: proposed fix for pnpm dev #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1e9f3
fix: proposed fix for pnpm dev
aiyazmostofa Jul 17, 2025
184a469
Merge branch 'main' into aiyazmostofa/fix-pnpm-dev
doprz Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@commitlint/cli": "^19.7.1",
"@commitlint/config-conventional": "^19.7.1",
"@commitlint/types": "^19.5.0",
"@crxjs/vite-plugin": "2.0.0-beta.21",
"@crxjs/vite-plugin": "2.0.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good to update but this causes a build error for pnpm build because of defineManifest changing

pnpm build needs to work, and don't just // @ts-ignore

"@iconify-json/bi": "^1.2.2",
"@iconify-json/ic": "^1.2.2",
"@iconify-json/iconoir": "^1.2.7",
Expand Down Expand Up @@ -154,7 +154,6 @@
},
"pnpm": {
"patchedDependencies": {
"@crxjs/[email protected]": "patches/@[email protected]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're completely getting rid of the path, the patch file should also be deleted

"@unocss/vite": "patches/@unocss__vite.patch"
},
"overrides": {
Expand Down
73 changes: 11 additions & 62 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ export default defineConfig({
server: {
strictPort: true,
port: 5173,
cors: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hmr: {
clientPort: 5173,
},
Expand Down
Loading