fix: proposed fix for pnpm dev #616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doprz
requested changes
Jul 17, 2025
Samathingamajig
requested changes
Jul 19, 2025
| }, | ||
| "pnpm": { | ||
| "patchedDependencies": { | ||
| "@crxjs/[email protected]": "patches/@[email protected]", |
There was a problem hiding this comment.
If we're completely getting rid of the path, the patch file should also be deleted
| server: { | ||
| strictPort: true, | ||
| port: 5173, | ||
| cors: true, |
| "@commitlint/config-conventional": "^19.7.1", | ||
| "@commitlint/types": "^19.5.0", | ||
| "@crxjs/vite-plugin": "2.0.0-beta.21", | ||
| "@crxjs/vite-plugin": "2.0.3", |
There was a problem hiding this comment.
it's good to update but this causes a build error for pnpm build because of defineManifest changing
pnpm build needs to work, and don't just // @ts-ignore
|
Succeeded by #627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes something.
First problem I encountered was that a script wasn't loading due to CORS interfering.
This was solved using this section of the Vite docs: https://vite.dev/config/server-options.html#server-cors. Notice that I set the value to true, which means the most liberal enforcement of CORS. This might be in your interest to change.
Second problem that came after solving this first one was that a script seemed to be broken. Here was the error:
After tracking down the script, I found it inside the source code for CRX.js (inside node_modules). This indicated that this was a bug with this dependency (which makes sense since the version yall are using is a beta). So I updated that to the latest version. I did this without consideration for breaking changes, which might be of your concern.
However, that seems to have fixed this issue. Rebuilds seem to happen quick now, so this might be a replacement to
build:watch.This change is