Refactor #62 api 응답 형식 변경, @parameter(hidden = true) 추가 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
huncozyboy
changed the title
jj0526
approved these changes
Oct 26, 2024
huncozyboy
changed the title
huncozyboy
added a commit
that referenced
this pull request
Oct 29, 2024
Refactor #63 스웨거 컨트롤러마다 설명 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
이 PR은 공통 응답 클래스를 리팩토링하여 성공 응답을 커스텀할 수 있도록 수정하고
각 도메인 관련 성공 응답을 수정하였습니다. 각 도메인마다 에러 메시지를 enum으로 관리하도록 수정했습니다
CurrentUser가 적용된 API에서 사용자 ID를 스웨거에서 파라미터로 입력하는 부분을 안뜨게 수정했습니다
PR 세부사항
CommonResponse, Schedule , User, Penalty, Comment, Board, Attendance, Account 도메인 -> 관련 성공 응답 수정 및 에러 메시지 추가
@currentuser 적용 컨트롤러 -> @parameter(hidden = true) 추가
관련 스크린샷
주의사항
체크 리스트