Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #62 api 응답 형식 변경 #62

Closed
2 tasks done
huncozyboy opened this issue Oct 25, 2024 · 0 comments · Fixed by #63
Closed
2 tasks done

Refactor #62 api 응답 형식 변경 #62

huncozyboy opened this issue Oct 25, 2024 · 0 comments · Fixed by #63
Assignees
@huncozyboy
Labels
refactor

Comments

@huncozyboy
Copy link
Member

huncozyboy commented Oct 25, 2024 •
edited
Loading

🚨 무슨 이유로 코드를 바꾸나요?

모든 API의 성공 응답 메시지를 200으로만 반환하고 있기 때문에 변경
@currentuser가 적용된 API에서 사용자 ID를 스웨거에서 입력하도록 요구하는 비효율적이기 때문에 변경

💭 어떻게 수정할 건가요?

  • ResponseMessage라는 enum을 생성해서 모든 api에 상수로 응답 메시지를 추가. 응답 메시지는 presentation 내부에 enum 형태로 생성
  • @parameter(hidden = true)를 적용하여 스웨거에서 @currentuser를 입력하지 않아도 되도록 처리
@huncozyboy huncozyboy self-assigned this Oct 25, 2024
@huncozyboy huncozyboy changed the title Refactor #62 api 성공 응답 형식 변경 Refactor #62 api 응답 형식 변경 Oct 25, 2024
@huncozyboy huncozyboy linked a pull request Oct 25, 2024 that will close this issue
Refactor #62 api 응답 형식 변경, @parameter(hidden = true) 추가 #63
Merged
5 tasks
huncozyboy added a commit that referenced this issue Oct 26, 2024
@huncozyboy
Merge pull request #63 from Leets-Official/Refactor-#62-api-응답-형식-변경-…
d8cac32 
…및-커런트-유저-관련-수정

Refactor #62 api 응답 형식 변경,  @parameter(hidden = true) 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huncozyboy huncozyboy

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor #62 api 응답 형식 변경, @parameter(hidden = true) 추가 Leets-Official/Weeth-BE
1 participant
@huncozyboy