[로또 게임] 이세원 과제 제출합니다. #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme 추가
KeonHee
requested changes
Jul 9, 2023
| private final CountMatch countMatch; | ||
| private List<Lotto>lottoList; | ||
|
|
||
| public Game(Input input, Print print, CountMatch countMatch){ |
| System.out.println(cycle + "개를 구매했습니다."); | ||
|
|
||
| // 3. 수량만큼 로또 번호 생성 | ||
| makeRandomLottoNumbers(cycle,lottoList); |
There was a problem hiding this comment.
static 함수로 만들어서 사용하는 것과 countMatch.countMatchNumber 처럼 외부에서 주입받아서 함수를 사용하는 것이 어떤 기준으로 다른 방식으로 구현한건가요?
KeonHee
reviewed
Jul 10, 2023
| private List<Lotto>lottoList; | ||
|
|
||
| public LottoGame(Input input, Print print, CountMatch countMatch){ | ||
| this.input = input; |
There was a problem hiding this comment.
Game이 아니라 파라미터로 들어오는 Input, Print, CountMatch들을 인터페이스화 시키라는 뜻이었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
클래스를 적절하게 분리하는 부분과,
번호 일치여부 판별 및 당첨금 계산 부분에서 어려움을 겪었습니다.
인터페이스 사용과 enum 사용이 어려워서 사용해보지 못했는데, 남은시간 더 노력해보겠습니다.