Skip to content

test(ci): add strict runtime contract gate #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KooshaPari wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(ci): add strict runtime contract gate #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,24 @@
npm test 2>&1 || echo "::warning::test failures (advisory)"
fi

runtime-contract-tests:
name: Runtime Contract Tests
runs-on: ubuntu-latest
Comment on lines +174 to +176

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Feed contract failures into the stable test gate

When branch protection relies on the stable ci / test check, a failure in this new job does not block that check: the downstream test job still has only needs: [lint] and unconditionally reports success. Wire runtime-contract-tests into that gate and make the gate fail when its result is not successful; otherwise a broken ACP/MCP/PTY/desktop contract can retain a green required test status.

Useful? React with 👍 / 👎.

steps:
- uses: actions/checkout@v4
- name: Setup Bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6
- name: Install locked Bun dependencies
run: bun install --frozen-lockfile

Check warning on line 182 in .github/workflows/ci.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--ignore-scripts" allows lifecycle scripts to run during package installation. 


See more on https://sonarcloud.io/project/issues?id=KooshaPari_colab&issues=AaBHjLF2MFsKsCNwqJDb&open=AaBHjLF2MFsKsCNwqJDb&pullRequest=160
- name: Run ACP, MCP, PTY, and desktop unit contracts
run: |
bun test --preload ./tests/setup-dom.ts --timeout 30000 \
apps/runtime/src/providers/__tests__/acp-client.test.ts \
apps/runtime/src/providers/__tests__/mcp-bridge*.test.ts \
apps/runtime/src/pty/__tests__ \
apps/runtime/tests/unit/pty \
apps/desktop/tests/unit

security:
name: Security Scan
needs: detect
Expand Down Expand Up @@ -241,4 +259,4 @@
- name: Test gate
run: |
# Test gate is currently combined with lint
echo "✅ All test stages passed (gated via ci / lint)"
echo "✅ All test stages passed (gated via ci / lint)"
Loading