test(ci): add strict runtime contract gate - #160
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
|
Compliance Check ✅All constitution compliance checks passed! |
Please ensure all checks pass before merging. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88c77b2955
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| runtime-contract-tests: | ||
| name: Runtime Contract Tests | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
When branch protection relies on the stable ci / test check, a failure in this new job does not block that check: the downstream test job still has only needs: [lint] and unconditionally reports success. Wire runtime-contract-tests into that gate and make the gate fail when its result is not successful; otherwise a broken ACP/MCP/PTY/desktop contract can retain a green required test status.
Useful? React with 👍 / 👎.
Quality Gate Report✅ Unit Tests: PASSED |
User description
Adds one independent, fail-closed
Runtime Contract TestsCI job. It installs the locked Bun graph and explicitly preloadstests/setup-dom.ts, then runs ACP, MCP bridge, PTY, and desktop unit-test surfaces. It is intentionally separate from the failing repository-wide typecheck; there is nocontinue-on-error,|| true, contract-content change, or test skip.CodeAnt-AI Description
Add a strict CI gate for runtime contract tests
What Changed
Impact
✅ Runtime contract regressions block CI✅ ACP, MCP, PTY, and desktop behavior is checked on every change✅ Reproducible test setup from the locked dependency graph💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.