Skip to content

fix(ci): restore Stage Gate command contracts #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KooshaPari wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −0
Open

fix(ci): restore Stage Gate command contracts #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58b3916
fix(ci): restore Stage Gate command contracts
KooshaPari Aug 28, 2026
6330ad5
fix(ci): scope format check to active source roots
KooshaPari Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"main": "index.js",
"scripts": {
"setup": "bun run scripts/setup-deps.ts",
"format:check": "biome check --config-path=biome.json apps packages scripts src tests",

@kilo-code-bot kilo-code-bot Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: format:check uses biome check, which runs lint rules in addition to format checks. If the gate is intended to validate only formatting, biome format would be more precise; lint failures unrelated to formatting will also block this command.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

"test": "bun test apps/runtime/src apps/runtime/tests/unit apps/desktop/tests/unit packages/*/tests scripts/tests tests/unit",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install dependencies for every selected test suite

On a clean Stage Gates runner, unit-check performs only the root bun install, but the root manifest declares no workspaces before this command selects nested package tests. For example, packages/logger/tests/logger.test.ts loads pino, which is declared only in packages/logger/package.json, and six selected provider tests import vitest, which is not declared by any manifest. Consequently bun run test terminates with module-resolution errors before running the assertions; either install the nested projects and declare vitest, or restrict this alias to suites supported by the root installation.

Useful? React with 👍 / 👎.

@kilo-code-bot kilo-code-bot Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: packages/*/tests relies on shell glob expansion. If no package directory contains a tests subdirectory, Bash passes the literal string packages/*/tests to bun test, which then fails to resolve the non-existent path.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

"test:coverage": "bun run tools/gates/runtime-coverage.mjs",
"build:dev": "bun setup && electrobun build",
"dev": "bun setup && electrobun dev",
"build:canary": "electrobun build --env=canary",
Expand Down Expand Up @@ -63,6 +66,7 @@
},
"devDependencies": {
"@axe-core/playwright": "^4.10.0",
"@biomejs/biome": "2.5.11",
"@playwright/test": "^1.48.0",
"@types/bun": "^1.1.0",
"happy-dom": "^15.0.0",
Expand Down
Loading