fix(ci): restore Stage Gate command contracts - #156
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Please ensure all checks pass before merging. |
Compliance Check ✅All constitution compliance checks passed! |
codeant-ai
Bot
added
the
size:XS
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58b3916a36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "scripts": { | ||
| "setup": "bun run scripts/setup-deps.ts", | ||
| "format:check": "biome check .", | ||
| "test": "bun test apps/runtime/src apps/runtime/tests/unit apps/desktop/tests/unit packages/*/tests scripts/tests tests/unit", |
There was a problem hiding this comment.
On a clean Stage Gates runner, unit-check performs only the root bun install, but the root manifest declares no workspaces before this command selects nested package tests. For example, packages/logger/tests/logger.test.ts loads pino, which is declared only in packages/logger/package.json, and six selected provider tests import vitest, which is not declared by any manifest. Consequently bun run test terminates with module-resolution errors before running the assertions; either install the nested projects and declare vitest, or restrict this alias to suites supported by the root installation.
Useful? React with 👍 / 👎.
| "main": "index.js", | ||
| "scripts": { | ||
| "setup": "bun run scripts/setup-deps.ts", | ||
| "format:check": "biome check .", |
There was a problem hiding this comment.
In every Stage Gates context, format-check now runs this command against the entire tracked tree, but existing files do not conform to the active Biome configuration. For example, biome.json requires double-quoted JavaScript while packages/logger/src/index.ts:9 uses single quotes, and multiple nested manifests use spaces rather than Biome's default tab indentation. Because biome check reports these formatter diagnostics without applying fixes, the newly restored command still leaves the format job red for every PR; format the baseline or narrow/exclude the legacy tree before making this the gate.
Useful? React with 👍 / 👎.
Please ensure all checks pass before merging. |
Compliance Check ✅All constitution compliance checks passed! |
Quality Gate Report❌ Unit Tests: FAILED |
|
Quality Gate Report✅ Unit Tests: PASSED |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| "main": "index.js", | ||
| "scripts": { | ||
| "setup": "bun run scripts/setup-deps.ts", | ||
| "format:check": "biome check --config-path=biome.json apps packages scripts src tests", |
There was a problem hiding this comment.
WARNING: format:check uses biome check, which runs lint rules in addition to format checks. If the gate is intended to validate only formatting, biome format would be more precise; lint failures unrelated to formatting will also block this command.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| "scripts": { | ||
| "setup": "bun run scripts/setup-deps.ts", | ||
| "format:check": "biome check --config-path=biome.json apps packages scripts src tests", | ||
| "test": "bun test apps/runtime/src apps/runtime/tests/unit apps/desktop/tests/unit packages/*/tests scripts/tests tests/unit", |
There was a problem hiding this comment.
WARNING: packages/*/tests relies on shell glob expansion. If no package directory contains a tests subdirectory, Bash passes the literal string packages/*/tests to bun test, which then fails to resolve the non-existent path.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Warnings | Recommendation: Approve with notes Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by free · Input: 33.6K · Output: 9.6K · Cached: 135K |
User description
Summary
Restores the three command contracts invoked by
Stage Gateswithout changing the workflow:@biomejs/biome2.5.11; addsformat:checkasbiome check ..test:coverage, delegating to the existingtools/gates/runtime-coverage.mjsthreshold gate (default 85%).Scope
Only
package.jsonandbun.lockchanged. The Stage Gates workflow, lint command, synthetic coverage manifest, secrets, and dependencies unrelated to Biome are untouched.Validation
bun add --dev --lockfile-only --save-text-lockfile @biomejs/biome@2.5.11generated a narrow lockfile delta: root devDependency plus Biome and its eight platform binaries.package.jsonadditions and 19bun.lockadditions.CodeAnt-AI Description
Restore the commands required for Stage Gates
What Changed
Impact
✅ Stage Gates can run all required commands✅ Consistent formatting checks across CI✅ Coverage thresholds enforced in CI💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.