-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only check if condition contained in ensuring gateway associated of httproute #3346
Conversation
Codecov ReportBase: 74.2% // Head: 74.2% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
=====================================
Coverage 74.2% 74.2%
=====================================
Files 110 110
Lines 13227 13233 +6
=====================================
+ Hits 9818 9831 +13
+ Misses 2787 2782 -5
+ Partials 622 620 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, some nits but overall 👍
6567405
to
3c11985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this shouldn't actually get its own changelog entry. Do you mind adding it @randmonkey ?
3c11985
to
66c8251
Compare
Added changelogs. |
174b992
to
5a87f79
Compare
Created Kong/kubernetes-testing-framework#489 to cover the failure in tests
oh, what a chance |
What this PR does / why we need it:
Now more than one conditions are added to HTTPRoute.status.parentStatus[*], so we need to change the method to check if parent status for gateways changed. Instead of making a full comparison of conditions, we check if the existing parentStatus contains the expected condtion.
Which issue this PR fixes:
fixes #3345
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR