Skip to content

Commit

Permalink
add CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
randmonkey committed Jan 9, 2023
1 parent 66c8251 commit 174b992
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ Adding a new version? You'll need three changes:

- Disabled non-functioning mesh reporting when `--watch-namespaces` flag set.
[#3336](https://github.com/Kong/kubernetes-ingress-controller/pull/3336)
- Fixed the duplicate update of status of `HTTPRoute` caused by incorrect check
of whether status is changed
[#3346](https://github.com/Kong/kubernetes-ingress-controller/pull/3346)

### Deprecated

Expand Down
13 changes: 6 additions & 7 deletions internal/controllers/gateway/route_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -631,11 +631,10 @@ func isHTTPReferenceGranted(grantSpec gatewayv1alpha2.ReferenceGrantSpec, backen
return false
}

// sameCondition returns true if the condition has the same type, status, reason and message
// with expectedCondition.
func sameCondition(expectedCondition metav1.Condition, condition metav1.Condition) bool {
return condition.Type == expectedCondition.Type &&
condition.Status == expectedCondition.Status &&
condition.Reason == expectedCondition.Reason &&
condition.Message == expectedCondition.Message
// sameCondition returns true if the conditions in parameter has the same type, status, reason and message.
func sameCondition(a, b metav1.Condition) bool {
return a.Type == b.Type &&
a.Status == b.Status &&
a.Reason == b.Reason &&
a.Message == b.Message
}

0 comments on commit 174b992

Please sign in to comment.