Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.8.x] fix(rate-limiting): do not set response headers if conf.hide_client_headers is true #13759

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[backport -> release/3.8.x] fix(rate-limiting): do not set response headers if conf.hide_client_headers is true #13759

merged 1 commit into from
Oct 16, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.8.x, triggered by a label in #13722.

Original description

Please REBASE and MERGE

Summary

Fix #13715, we should not set the response header if conf.hide_client_headers is true.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

#13715, KAG-5492

@ADD-SP @github-actions
fix(rate-limiting): do not set response headers if `conf.hide_client_…
8d3bad6 
…headers` is `true` (#13722)

Fix #13715; we should not set the response header if `conf.hide_client_headers` is `true`.

(cherry picked from commit cf403a7)
@team-gateway-bot team-gateway-bot mentioned this pull request Oct 16, 2024
Merged
2 tasks
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 16, 2024
@ADD-SP ADD-SP removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 16, 2024
@ADD-SP ADD-SP merged commit ce524d3 into release/3.8.x Oct 16, 2024
41 checks passed
@ADD-SP ADD-SP deleted the backport-13722-to-release/3.8.x branch October 16, 2024 08:20
@kevwilliams kevwilliams added this to the 3.8.1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@ADD-SP ADD-SP

Labels
plugins/rate-limiting size/M
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@team-gateway-bot @ADD-SP @StarlightIbuki @kevwilliams